Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 1.2.0 commit #132

Merged
merged 1 commit into from
Aug 4, 2022
Merged

Release 1.2.0 commit #132

merged 1 commit into from
Aug 4, 2022

Conversation

csmart
Copy link
Collaborator

@csmart csmart commented Aug 4, 2022

SUMMARY

New release 1.2.0

@csmart
Copy link
Collaborator Author

csmart commented Aug 4, 2022

As per #81 (comment)

@Andersson007
Copy link
Contributor

@csmart there's a strange mismatch between the changelog and tags

@csmart
Copy link
Collaborator Author

csmart commented Aug 4, 2022

@Andersson007 thank you! Yes, I pushed the wrong branch...

Copy link
Contributor

@Andersson007 Andersson007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM now:) Thanks

@csmart csmart merged commit cc8bd07 into main Aug 4, 2022
@csmart csmart deleted the release_branch branch August 4, 2022 11:39
dseeley added a commit to dseeley/community.libvirt that referenced this pull request Oct 17, 2022
* main:
  Improved domain definition handling
  Parse incoming XML instead of using regex to get name
  Refactor define command handling into separate function
  CI: add 2.14 tests, ignore-2.15 to avoid CI failing
  doc: set booleans to true/false for consistency
  Combine REVIEW_CHECKLIST.md and CONTRIBUTING.md and fix links
  CI: remove f35 from devel
  fix up failing pylint test, use before assignment
  Fix virt module to undefine a domain with nvram or other metadata (ansible-collections#136)
  Replace discouraged function listVolumes (ansible-collections#135)
  Replace functions listStoragePools and listDefinedStoragePools (ansible-collections#134)
  Update galaxy to next expected release (ansible-collections#133)
  Release 1.2.0 commit (ansible-collections#132)
dseeley pushed a commit to dseeley/community.libvirt that referenced this pull request Oct 17, 2022
# By Chris Smart (6) and others
# Via Chris Smart
* main:
  Improved domain definition handling
  Parse incoming XML instead of using regex to get name
  Refactor define command handling into separate function
  CI: add 2.14 tests, ignore-2.15 to avoid CI failing
  doc: set booleans to true/false for consistency
  Combine REVIEW_CHECKLIST.md and CONTRIBUTING.md and fix links
  CI: remove f35 from devel
  fix up failing pylint test, use before assignment
  Fix virt module to undefine a domain with nvram or other metadata (ansible-collections#136)
  Replace discouraged function listVolumes (ansible-collections#135)
  Replace functions listStoragePools and listDefinedStoragePools (ansible-collections#134)
  Update galaxy to next expected release (ansible-collections#133)
  Release 1.2.0 commit (ansible-collections#132)
dseeley pushed a commit to dseeley/community.libvirt that referenced this pull request Oct 17, 2022
# By Chris Smart (6) and others
# Via Chris Smart
* main:
  Improved domain definition handling
  Parse incoming XML instead of using regex to get name
  Refactor define command handling into separate function
  CI: add 2.14 tests, ignore-2.15 to avoid CI failing
  doc: set booleans to true/false for consistency
  Combine REVIEW_CHECKLIST.md and CONTRIBUTING.md and fix links
  CI: remove f35 from devel
  fix up failing pylint test, use before assignment
  Fix virt module to undefine a domain with nvram or other metadata (ansible-collections#136)
  Replace discouraged function listVolumes (ansible-collections#135)
  Replace functions listStoragePools and listDefinedStoragePools (ansible-collections#134)
  Update galaxy to next expected release (ansible-collections#133)
  Release 1.2.0 commit (ansible-collections#132)
dseeley added a commit to dseeley/community.libvirt that referenced this pull request Oct 17, 2022
* modules_virt_additions:
  Improved domain definition handling
  Parse incoming XML instead of using regex to get name
  Refactor define command handling into separate function
  CI: add 2.14 tests, ignore-2.15 to avoid CI failing
  doc: set booleans to true/false for consistency
  Combine REVIEW_CHECKLIST.md and CONTRIBUTING.md and fix links
  CI: remove f35 from devel
  fix up failing pylint test, use before assignment
  Fix virt module to undefine a domain with nvram or other metadata (ansible-collections#136)
  Replace discouraged function listVolumes (ansible-collections#135)
  Replace functions listStoragePools and listDefinedStoragePools (ansible-collections#134)
  Update galaxy to next expected release (ansible-collections#133)
  Release 1.2.0 commit (ansible-collections#132)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants