-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release 1.2.0 commit #132
Merged
Merged
Release 1.2.0 commit #132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As per #81 (comment) |
@csmart there's a strange mismatch between the changelog and tags |
@Andersson007 thank you! Yes, I pushed the wrong branch... |
Andersson007
approved these changes
Aug 4, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM now:) Thanks
dseeley
added a commit
to dseeley/community.libvirt
that referenced
this pull request
Oct 17, 2022
* main: Improved domain definition handling Parse incoming XML instead of using regex to get name Refactor define command handling into separate function CI: add 2.14 tests, ignore-2.15 to avoid CI failing doc: set booleans to true/false for consistency Combine REVIEW_CHECKLIST.md and CONTRIBUTING.md and fix links CI: remove f35 from devel fix up failing pylint test, use before assignment Fix virt module to undefine a domain with nvram or other metadata (ansible-collections#136) Replace discouraged function listVolumes (ansible-collections#135) Replace functions listStoragePools and listDefinedStoragePools (ansible-collections#134) Update galaxy to next expected release (ansible-collections#133) Release 1.2.0 commit (ansible-collections#132)
dseeley
pushed a commit
to dseeley/community.libvirt
that referenced
this pull request
Oct 17, 2022
# By Chris Smart (6) and others # Via Chris Smart * main: Improved domain definition handling Parse incoming XML instead of using regex to get name Refactor define command handling into separate function CI: add 2.14 tests, ignore-2.15 to avoid CI failing doc: set booleans to true/false for consistency Combine REVIEW_CHECKLIST.md and CONTRIBUTING.md and fix links CI: remove f35 from devel fix up failing pylint test, use before assignment Fix virt module to undefine a domain with nvram or other metadata (ansible-collections#136) Replace discouraged function listVolumes (ansible-collections#135) Replace functions listStoragePools and listDefinedStoragePools (ansible-collections#134) Update galaxy to next expected release (ansible-collections#133) Release 1.2.0 commit (ansible-collections#132)
dseeley
pushed a commit
to dseeley/community.libvirt
that referenced
this pull request
Oct 17, 2022
# By Chris Smart (6) and others # Via Chris Smart * main: Improved domain definition handling Parse incoming XML instead of using regex to get name Refactor define command handling into separate function CI: add 2.14 tests, ignore-2.15 to avoid CI failing doc: set booleans to true/false for consistency Combine REVIEW_CHECKLIST.md and CONTRIBUTING.md and fix links CI: remove f35 from devel fix up failing pylint test, use before assignment Fix virt module to undefine a domain with nvram or other metadata (ansible-collections#136) Replace discouraged function listVolumes (ansible-collections#135) Replace functions listStoragePools and listDefinedStoragePools (ansible-collections#134) Update galaxy to next expected release (ansible-collections#133) Release 1.2.0 commit (ansible-collections#132)
dseeley
added a commit
to dseeley/community.libvirt
that referenced
this pull request
Oct 17, 2022
* modules_virt_additions: Improved domain definition handling Parse incoming XML instead of using regex to get name Refactor define command handling into separate function CI: add 2.14 tests, ignore-2.15 to avoid CI failing doc: set booleans to true/false for consistency Combine REVIEW_CHECKLIST.md and CONTRIBUTING.md and fix links CI: remove f35 from devel fix up failing pylint test, use before assignment Fix virt module to undefine a domain with nvram or other metadata (ansible-collections#136) Replace discouraged function listVolumes (ansible-collections#135) Replace functions listStoragePools and listDefinedStoragePools (ansible-collections#134) Update galaxy to next expected release (ansible-collections#133) Release 1.2.0 commit (ansible-collections#132)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
New release 1.2.0